Add Koa 3 + MySQL test setup #348
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a clone of the existing koa-mysql setup, which uses Koa v2. Update Koa to v3 and koa-router to v15, which requires Node >= 20. Update Node.js image to v20.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
unflxw
approved these changes
Jan 5, 2026
Contributor
unflxw
left a comment
unflxw
left a comment
There was a problem hiding this comment.
Thank you for adding this! While we're here, could you rename the existing koa-* test setups to koa-2-* test setups, to avoid confusion?
| } | ||
| app.use(router.routes()).use(router.allowedMethods()); | ||
| app.listen(port); | ||
| console.log(`Example app listening on port ${port}`); |
Contributor
There was a problem hiding this comment.
I think the build artifacts should not be committed, unless we have a reason for doing so. They're not committed for the Koa 2 test setup, which has the dist/ folder on its .gitignore.
tombruijn
approved these changes
Jan 5, 2026
This comment has been minimized.
This comment has been minimized.
3 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This is a message from the daily scheduled checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Koa 3 + MySQL test setup
This is a clone of the existing
koa-mysqlsetup, which uses Koa v2.Update Koa to v3 and koa-router to v15, which requires Node >= 20.
Update Node.js image to v20.
Part of appsignal/appsignal-nodejs#1263