-
Notifications
You must be signed in to change notification settings - Fork 7
feat: add Aptabase.Core #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Fixes aptabase#4 The GitHub repository should be renamed to aptabase-dotnet following the merge of this pull request. Maui should work... (I can't test that, I'm on Fedora Linux)
I will add one thing though. The richness of the Maui data was decreased due to bar now being pure .NET 8. I will try and expand on the device model detection for other operating systems done the line but I believe this is a great start. If anything, |
Hi, everyone! I'd like to know what I'm missing so this can get merged. I know it's a big change but it'll allow my application SnapX to use it alongside Sentry for application analytics and seeing what features are being utilized by the userbase. |
This would be absolutly wonderful! We're about to keep old Xamarin apps alive (yeah, I know it's stupid) and we would like to use Aptabase.Core for those apps. Also, it could be used with console apps or other stuff. Make it work with netstandard2.0 and you're the heroes of many more people. |
Hi, I can investigate net standard as a target. I am going to finish up the last of this PR & test on Windows. The only thing that’s really missing here is ensuring Aptabase.Maui still reports the same ol data as before. |
I want to use this in a PowerShell module (comparable with console app, target wise). Can I help somewhere to get this pr moved on? |
Hi! I did more investigation, and the dependency I know this isn't the answer you wanted, however, you should give .NET 8 a try. Big projects that use numerous Windows API calls like ShareX in less than 1k LoC. Not to mention, they get a slight no-cost performance boost. I know having clients install the .NET 8 Desktop Runtime is troublesome; that's where NativeAOT comes in. |
I've looked into this a bit more. Looks cool how you can even use .NET (Formerly known as |
What is the purpose of the dependencies?
I would highly recommend to remove any unnecessary dependencies in Aptabase.Core (which targets plain .NET) to keep the acceptance high. |
Creating an event is just one http call right? Seeing how massive these changes are, I'll just be creating my own client and call it a day. Will built in in net standard 2.0, meaning it will work on both .net framework and .net core |
Xdg.Directories was added for That replaced this MAUI-specific LoC
|
The Aptabase SDKs do slightly more than that. They create a queue of sorts. They need to handle poor internet connectivity or no network at all, and send the data later when the network is available. (Data in limbo is saved on the disk) Additionally, they "batch" requests so the Aptabase server isn't spammed with HTTP requests because of multiple events being triggered in the span of a second. I understand your frustration with the |
It compiles on Windows 11 Pro 24H2 for me.
If it is more than 40 characters, Aptabase tells you to get lost.
Signed-off-by: Brycen G <[email protected]>
Signed-off-by: Brycen G <[email protected]>
Keeps all dependencies on MAUI in
Aptabase.Maui
but also moves all the independent code toAptabase.Core
which projects that don't use MAUI can useThe GitHub repository should be renamed to aptabase-dotnet following the merge of this pull request.
Maui should work...
(I can't test that, I'm on Fedora Linux)test/HelloMaui compiles on Windows 11 Pro 24H2
The core code is tested on Windows 11 Pro 24H2 and I have verified it works.
Fixes #4