-
Notifications
You must be signed in to change notification settings - Fork 6
feat: add react native web support #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
c309c37
to
bd56e18
Compare
@Robert27 thank you for your contribution. Can you please highlight in a comment here the differences in implementation between the two and the reasoning for explicit support for React Native Web? |
React Native Web has become increasingly popular, especially since Expo Web. The Bluesky web app, for example, is written with React Native Web. Specifically, I need this feature for my team, and I read the request in the discord. However, this SDK does not yet support the web platform. Implementing it turned out to be a bit more complicated, as different philosophies were chosen between native and web. |
I can absolutely relate on this PR. |
I have added all the desired changes and the web functionality is now opt-in. I was also able to solve all issues with the tests and also added new ones. In addition I also updated the documentation in the readme accordingly. My team is already using my fork in production and everything works without any problems. |
Added support for react native web by adapting the dispatcher behavior from
aptabase-js
.Resolves #12