fix: video player responsiveness#584
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request includes improvements to the handling and testing of preset options, as well as updates to the video player component's layout and styling. The most significant changes are the addition of unit tests for the
usePresetOptionscomposable, simplification of how preset options are used in several components, and enhancements to the video player UI.Testing improvements:
usePresetOptions.test.tsto verify correct grouping and ordering of presets, ensuring both the default and custom-first orderings are tested.tsconfig.jsonfor tests to ensure proper type checking and compatibility with the test environment.Preset option usage simplification:
usePresetOptionsinNewDownload.vue,Simple.vue, andTaskForm.vueby removing explicit ordering options, relying on the default behavior. [1] [2] [3]Video player UI improvements:
.playerand surrounding markup inVideoPlayer.vuefor better responsiveness and layout, including a new.player-shellwrapper and improved CSS for the video element. [1] [2]