minor bug fixes and overall ui improvements #586
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces the
download_skippedflag to track when downloads are intentionally skipped (e.g., via--skip-downloador--simulate) throughout the backend, persistence layer, and frontend UI. It ensures that the flag is set and propagated in download status updates, persisted in storage, and reflected in the UI to prevent retry actions and display appropriate icons and status messages. The changes also include improved handling of playlist metadata and comprehensive tests to verify the new behavior.Backend: Download Flow and Status Tracking
download_skippedboolean toItemDTOand updated the download logic incore.pyto detect when downloads are skipped based on yt-dlp options. This flag is now included in all status queue updates, ensuring accurate tracking and propagation.Frontend: UI/UX Updates
History.vuecomponent to use thedownload_skippedflag for determining retry action visibility, status icon, icon color, and status message, providing clear feedback when downloads are intentionally skipped. [1] [2] [3] [4] [5] [6] [7]