refactor: re-add the automatic history update after download#593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request refactors how history item moves are handled in the application by introducing a reusable handler and improving socket event integration. The main goal is to centralize and streamline the logic for updating the history state when items are moved, ensuring consistency across different components.
History Move Handling Refactor:
Introduced a new
historyMoveHandlerfunction inuseHistoryState.tsto encapsulate the logic for handling history item moves, making it reusable and easier to maintain. This handler updates the history state when an item is moved to history.In
history.vueandsimple.vuewe register theitem_movedsocket event using the new handler, to handle items update without the need to trigger full API request.