get_bbox_IJK Bug #147
Open
get_bbox_IJK Bug #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
get_bbox_IJK() assumes legacy material format and will raise error on the self.materials.values() call. Update function with new format, and keep legacy support.
Author
|
There are a few places in the Volume class now where there is a conflict in the expected materials type as mentioned above. Examples:
In v1.1.3 materials was Union[Dict[str, np.ndarray], but v1.2 > it's Tuple[Dict[str, int], np.ndarray]]. Should these instances be updated to Tuple[Dict[str, int], np.ndarray]] or should both types be supported as suggested in this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_bbox_IJK() assumes legacy material format and will raise error on the self.materials.values() call.
Update function with new format, and keep legacy support.