Make Cache Configurable#75
Open
DanielDango wants to merge 34 commits into
Open
Conversation
- add new redis cache replacement strategy
…pdate CacheManager to support initialization from ModuleConfiguration
…tegy to be more generic
…RedisCache to simplify as a regular cache
…e/add-cache-configurations # Conflicts: # src/main/java/edu/kit/kastel/sdq/lissa/ratlr/configuration/EvaluationConfiguration.java
…ature/add-cache-configurations # Conflicts: # src/test/java/edu/kit/kastel/sdq/lissa/ratlr/ArchitectureTest.java
…ions - aside from the local cache dir for replication - from individual environment variables.
…ion, and backward compatibility checks
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 11 out of 11 changed files in this pull request and generated 11 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 14 out of 14 changed files in this pull request and generated 6 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
dfuchss
reviewed
May 21, 2026
…propriate methods to avoid serialization conflicts
|
…e non-empty list. Also fail fast if configured caches are unavailable
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
dfuchss
approved these changes
Jun 24, 2026
Comment on lines
+161
to
+166
| String jsonValue; | ||
| try { | ||
| jsonValue = mapper.writeValueAsString(Objects.requireNonNull(value)); | ||
| } catch (JsonProcessingException e) { | ||
| throw new IllegalArgumentException("Could not serialize object", e); | ||
| } |
Comment on lines
+135
to
+141
| static <K extends CacheKey> Cache<K> createByType( | ||
| CacheType type, CacheParameter<K> parameters, @Nullable String cacheDir, @Nullable ObjectMapper mapper) { | ||
| return switch (type) { | ||
| case LOCAL -> new LocalCache<>(cacheDir, parameters); | ||
| case REDIS -> new RedisCache<>(parameters, mapper); | ||
| }; | ||
| } |
Comment on lines
+361
to
+375
| /** | ||
| * Rule that enforces that CacheManager.resetDefaultInstance() is only called from Test classes. | ||
| * <p> | ||
| * The resetDefaultInstance() method should only be used to reset the singleton state between tests. | ||
| * It must never be called from production code or other test classes. | ||
| */ | ||
| @ArchTest | ||
| static final ArchRule cacheManagerResetOnlyInTests = noClasses() | ||
| .that() | ||
| .haveNameNotMatching(".*Test.*") | ||
| .should() | ||
| .callMethod(CacheManager.class, "resetDefaultInstance") | ||
| .because( | ||
| "CacheManager.resetDefaultInstance() is only intended for testing purposes in CacheTest and must not be used elsewhere"); | ||
|
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to make caches in LiSSA configurable.
Caching with REST-Redis as in #59 can be added afterwards.
The current Redis and Local Cache implementations are split into independent implementations of the Cache interface. Instead, a new Cache, the hierarchical Cache, is added to define how two caches can be coupled. Hierarchical caches can also be coupled with another hierarchical cache. If values are missing in any level of the cache hierarchy, they will be propagated.
The CacheReplacementStrategy Enum describes different conflict resolution strategies (None / Error / Overwrite).
The strategy and general cache hierarchy are defined in environment variables with the defaults of local cache and no consequences on cache conflicts.
The internal local cache implementation has not been altered to keep support for existing local cache files. Their location continues to be specified by the configuration file to enable effortless replication.