Merged
Conversation
Signed-off-by: ubi de feo <me@ubidefeo.com>
There was a problem hiding this comment.
Copilot reviewed 27 out of 29 changed files in this pull request and generated 2 comments.
Files not reviewed (2)
- package.json: Language not supported
- ui/arduino/main.css: Language not supported
Comments suppressed due to low confidence (1)
ui/arduino/store.js:1633
- There is a potential memory leak here because every new tab registers an onChange listener without removing it when the tab is closed. Consider implementing a cleanup to remove the listener upon tab closure.
newFile.editor.onChange = function() { newFile.hasChanges = true; emitter.emit('render') }
| if (tooltip) { | ||
| tooltipEl = html`<div class="tooltip">${tooltip}</div>` | ||
| } | ||
| tooltipEl = html`` |
There was a problem hiding this comment.
Resetting tooltipEl to an empty value immediately after conditionally setting it discards any provided tooltip content. Remove or adjust this line so that the tooltip renders as intended.
Suggested change
| tooltipEl = html`` | |
Collaborator
Author
|
Converted to Draft since creation of files still somehow defaults to |
Signed-off-by: ubi de feo <me@ubidefeo.com>
Signed-off-by: ubi de feo <me@ubidefeo.com>
Signed-off-by: ubi de feo <me@ubidefeo.com>
Signed-off-by: ubi de feo <me@ubidefeo.com>
… mount-point. Signed-off-by: ubi de feo <me@ubidefeo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces detection of board's default root path, which may be
/or/flashdepending on ports.It seems that it will eventually standardise to
/flashfollowing the introduction of ROMFS.A typical scenario will be as described in this comment related to MAPFS (later called ROMFS)
micropython/micropython#8381 (comment)
With
/not being directly writable unless wanted by someone producing their own custom build, but I'd rather be future-proof with this double-handling based on the presence of/flashinsys.path.With this PR the creation of a new program will happen in
/flashfor boards which are already mounting the main file-system there and default to/for other platforms.Eventually all platforms should follow custom even if a board will never use an SD card or have ROMFS