chore: Initialize logging early and print version at startup#846
chore: Initialize logging early and print version at startup#846
Conversation
Signed-off-by: jannfis <jann@mistrust.net>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #846 +/- ##
==========================================
- Coverage 45.27% 45.25% -0.02%
==========================================
Files 118 118
Lines 16633 16635 +2
==========================================
- Hits 7530 7528 -2
- Misses 8410 8413 +3
- Partials 693 694 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
What does this PR do / why we need it:
This PR moves logging initialization to be the first thing on startup of both agent and principal, so that even a non-starting pod (i.e. due to missing certificates) will log its version information before any error aborts the execution.
Which issue(s) this PR fixes:
Fixes #?
How to test changes / Special notes to the reviewer:
Checklist