fix(ci): run pnpm install with --frozen-lockfile (#27098)

[dudinea]

Fixes: #27098

This PR adds --frozen-lockfile to yarn install invocations
in Dockerfiles, Makefile, and in the release Github workflow.

It adds recommendation to use this flag to UI development README.

Additionally it adds to the Makefile new target run-yarn that will
allow to modify UI dependencies by runing yarn in the containerized environment
and documents the changes in the Developer's Guide.

Checklist:

• Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
• The title of the PR states what changed and the related issues number (used for the release note).
• The title of the PR conforms to the Title of the PR
• I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
• I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
• Does this PR require documentation updates?
• I've updated documentation as required by this PR.
• I have signed off all my commits as required by DCO
• I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
• My build is green (troubleshooting builds).
• My new feature complies with the feature status guidelines.
• I have added a brief description of why this PR is necessary and/or what this PR solves.
• Optional. My organization is added to USERS.md.
• Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

[bunnyshell]

❌ Preview Environment deleted from Bunnyshell

Available commands (reply to this comment):

• 🚀 /bns:deploy to deploy the environment

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.33%. Comparing base (f86cd07) to head (6559894).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #27099      +/-   ##
==========================================
- Coverage   63.35%   63.33%   -0.03%     
==========================================
  Files         415      415              
  Lines       56654    56651       -3     
==========================================
- Hits        35895    35879      -16     
- Misses      17374    17385      +11     
- Partials     3385     3387       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[choejwoo]

argo-cd/Makefile

Lines 665 to 667 in fb1b240

	dep-ui-local:
	cd ui && yarn install

Generally LGTM, but I noticed this path still uses yarn install without --frozen-lockfile. Was that intentional?

[dudinea]

@choejwoo

I noticed this path still uses yarn install without --frozen-lockfile. Was that intentional?

Yes, it's the point of dep-ui-local target to update UI dependencies. It is usually used by the dep-ui that calls it inside docker container.

But, now on the second thought, thanks to your comment, I realized that this target is called by start-e2e which is part of the normal development cycle. That's not good, I'll fix this shortly.

[choejwoo]

I see what you mean, thanks for the quick fix. This looks good to me! 😁

[ppapapetrou76]

LGTM

[argo-cd-cherry-pick-bot]

❌ Cherry-pick failed for 3.4. Please check the workflow logs for details.

[argo-cd-cherry-pick-bot]

❌ Cherry-pick failed for 3.1. Please check the workflow logs for details.

[argo-cd-cherry-pick-bot]

❌ Cherry-pick failed for 3.2. Please check the workflow logs for details.

[argo-cd-cherry-pick-bot]

❌ Cherry-pick failed for 3.3. Please check the workflow logs for details.