fix(ui): add truncation and tooltip for long sync status branch names#27260
fix(ui): add truncation and tooltip for long sync status branch names#27260choejwoo wants to merge 6 commits intoargoproj:masterfrom
Conversation
Signed-off-by: choejwoo <jaewoo45@gmail.com>
Signed-off-by: choejwoo <jaewoo45@gmail.com>
✅ Preview Environment deployed on Bunnyshell
See: Environment Details | Pipeline Logs Available commands (reply to this comment):
|
There was a problem hiding this comment.
Pull request overview
Updates the Application “Sync Status” panel rendering to prevent very long target revisions (e.g., branch names) from widening the panel, while still keeping the resolved revision visible and discoverable via hover.
Changes:
- Extracted revision-suffix formatting into a reusable helper (
getSyncRevisionLabelSuffix) used by sync status rendering. - Updated the status panel to render Synced/OutOfSync revisions with truncation +
titletooltip for full branch name, while preserving existing rendering for other sync states. - Added SCSS rules to constrain width and apply ellipsis truncation for long revision labels.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ui/src/app/applications/components/utils.tsx | Extracts revision-suffix formatting logic into a helper reused by multiple UI render paths. |
| ui/src/app/applications/components/application-status-panel/application-status-panel.tsx | Introduces a dedicated renderer for sync revision display (truncation + tooltip) in Synced/OutOfSync states. |
| ui/src/app/applications/components/application-status-panel/application-status-panel.scss | Adds flex/overflow/ellipsis styling to prevent long revisions from expanding the status panel. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ui/src/app/applications/components/application-status-panel/application-status-panel.tsx
Show resolved
Hide resolved
ui/src/app/applications/components/application-status-panel/application-status-panel.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: choejwoo <jaewoo45@gmail.com>
Signed-off-by: choejwoo <jaewoo45@gmail.com>
Signed-off-by: choejwoo <jaewoo45@gmail.com>
Signed-off-by: choejwoo <jaewoo45@gmail.com>
|
@crenshaw-dev |
Fixes #27200
This updates the Sync Status panel so long branch names are truncated with an ellipsis while keeping the revision visible, and shows the full branch name on hover. It also preserves the existing rendering for non-Synced and non-OutOfSync states.
Added a small helper for tooltip and revision-specific rendering, and split the existing utils logic slightly so the status panel can reuse the same formatting rules.
Long branch name with tooltip
Normal branch 1
Normal branch 2
When the status is neither Synced nor OutOfSync
Checklist: