Skip to content

fix(ui): add truncation and tooltip for long sync status branch names#27260

Open
choejwoo wants to merge 6 commits intoargoproj:masterfrom
choejwoo:fix/sync-status-branch-truncation
Open

fix(ui): add truncation and tooltip for long sync status branch names#27260
choejwoo wants to merge 6 commits intoargoproj:masterfrom
choejwoo:fix/sync-status-branch-truncation

Conversation

@choejwoo
Copy link
Copy Markdown
Member

@choejwoo choejwoo commented Apr 9, 2026

Fixes #27200

This updates the Sync Status panel so long branch names are truncated with an ellipsis while keeping the revision visible, and shows the full branch name on hover. It also preserves the existing rendering for non-Synced and non-OutOfSync states.

Added a small helper for tooltip and revision-specific rendering, and split the existing utils logic slightly so the status panel can reuse the same formatting rules.

Long branch name with tooltip

스크린샷 2026-04-10 오전 12 12 29

Normal branch 1

스크린샷 2026-04-10 오전 12 22 25

Normal branch 2

스크린샷 2026-04-10 오전 12 31 30

When the status is neither Synced nor OutOfSync

스크린샷 2026-04-10 오전 12 08 19

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: choejwoo <jaewoo45@gmail.com>
@choejwoo choejwoo requested a review from a team as a code owner April 9, 2026 15:28
@bunnyshell
Copy link
Copy Markdown

bunnyshell bot commented Apr 9, 2026

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-ehmwql.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-ehmwql.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Application “Sync Status” panel rendering to prevent very long target revisions (e.g., branch names) from widening the panel, while still keeping the resolved revision visible and discoverable via hover.

Changes:

  • Extracted revision-suffix formatting into a reusable helper (getSyncRevisionLabelSuffix) used by sync status rendering.
  • Updated the status panel to render Synced/OutOfSync revisions with truncation + title tooltip for full branch name, while preserving existing rendering for other sync states.
  • Added SCSS rules to constrain width and apply ellipsis truncation for long revision labels.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
ui/src/app/applications/components/utils.tsx Extracts revision-suffix formatting logic into a helper reused by multiple UI render paths.
ui/src/app/applications/components/application-status-panel/application-status-panel.tsx Introduces a dedicated renderer for sync revision display (truncation + tooltip) in Synced/OutOfSync states.
ui/src/app/applications/components/application-status-panel/application-status-panel.scss Adds flex/overflow/ellipsis styling to prevent long revisions from expanding the status panel.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: choejwoo <jaewoo45@gmail.com>
Signed-off-by: choejwoo <jaewoo45@gmail.com>
Signed-off-by: choejwoo <jaewoo45@gmail.com>
Signed-off-by: choejwoo <jaewoo45@gmail.com>
@choejwoo
Copy link
Copy Markdown
Member Author

choejwoo commented Apr 9, 2026

@crenshaw-dev
I've created another PR to address all comments. While reviewing the previous two PRs, I found a few additional cases to verify and a small helper refactor.
Since the change ended up a bit larger, I'd appreciate another look when you have time. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

"Sync Status" panel gets too wide with very long branch names

2 participants