Skip to content

chore: camelCase keys in topo health json output - #55

Merged
awphi merged 2 commits into
mainfrom
awphi/snake-case-health
Mar 2, 2026
Merged

chore: camelCase keys in topo health json output#55
awphi merged 2 commits into
mainfrom
awphi/snake-case-health

Conversation

@awphi

@awphi awphi commented Feb 26, 2026

Copy link
Copy Markdown
Contributor

Changes

  • Does what it says on the tin. Allows us to have more standard-looking JS objects in the vscode extension + rename props on these structs without breaking the extension in the future

Why is the branch called snake-case but the PR is in camelCase? I changed my mind after pushing the branch

@awphi
awphi requested a review from a team as a code owner February 26, 2026 16:04
@awphi
awphi marked this pull request as draft February 26, 2026 16:10
Signed-off-by: awphi <26072111+awphi@users.noreply.github.com>
@awphi
awphi force-pushed the awphi/snake-case-health branch from 48578c5 to 493b70a Compare February 26, 2026 17:22
@awphi
awphi marked this pull request as ready for review February 27, 2026 10:05
@awphi awphi changed the title chore: snake-case keys in topo health json output chore: snake_case keys in topo health json output Feb 27, 2026
@awphi
awphi marked this pull request as draft February 27, 2026 10:15
Signed-off-by: awphi <26072111+awphi@users.noreply.github.com>
@awphi awphi changed the title chore: snake_case keys in topo health json output chore: camelCase keys in topo health json output Feb 27, 2026
@awphi
awphi marked this pull request as ready for review February 27, 2026 10:25

@logan-scully-arm logan-scully-arm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@awphi
awphi merged commit 01a13ca into main Mar 2, 2026
5 of 6 checks passed
@awphi
awphi deleted the awphi/snake-case-health branch March 2, 2026 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants