Conversation
artempyanykh
left a comment
There was a problem hiding this comment.
This is great! Thanks for the contribution @ficd0!
The change looks good to me, modulo a few suggested improvements. Let me know if you want to address those.
|
I'm happy to address them, thanks for the helpful review comments. I'll mark ping you here when it's ready for review. 🙂 |
Added config option code_action.toc.include which is a list of integers. These are the heading levels that will be included when generating a Table of Contents. Updated tests accordingly. Partially implements artempyanykh#91
|
@artempyanykh ready for review, thanks for all the guidance! I have some experience with OCaml but it's my first time programming in F# |
|
Thanks for the contribution @ficd0! |
|
Thanks for the merge and for fixing my mistakes in the next commit. I'm too used to 1. Ocaml syntax for type constructors like Since F# allows P.S. getting my development environment set up and figuring out how to run tests, formatting etc. Was a bit challenging. I think some contributor documentation would be super helpful for new contributors! |
|
@ficd0 no worries at all, appreciate the contribution! Agreed that contributor's guide would be helpful. |
Added config option
code_action.toc.includewhich is a list of integers. This isthe new default:
These are the heading levels that will be included when generating a Table of
Contents. Keeping the default setting results in identical behavior to before.
However, changing the array allows us to exclude certain levels from the TOC.
I updated tests accordingly. This PR partially implements #91.
Asciicast demo available: