feat(parser): Enable Markdig Mathematics extension#449
Merged
artempyanykh merged 1 commit intoartempyanykh:mainfrom Jan 24, 2026
Merged
feat(parser): Enable Markdig Mathematics extension#449artempyanykh merged 1 commit intoartempyanykh:mainfrom
artempyanykh merged 1 commit intoartempyanykh:mainfrom
Conversation
| let actual = scrapeString content | ||
| checkInlineSnapshot actual [] | ||
|
|
||
| module MathBlockTests = |
Owner
There was a problem hiding this comment.
❤️ Appreciate you adding tests!
Owner
|
Brilliant! Thanks for the contribution @abap34!
Appreciate you calling this out. I think it should be fine. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for your continued maintenance work! I use marksman heavily for note-taking, and it has been extremely helpful.
Summary
As reported in #326, marksman currently produces incorrect diagnostics inside math blocks.
For example, bracket pairs can be interpreted as links (including wiki-links), which results in false, non-existent errors.
Another example (wiki-link):
To address this, this PR enables Markdig’s Mathematics extension via
.UseMathematics().This should make marksman treat
$...$/$$...$$regions as math and avoid applying link parsing and link-related diagnostics inside them, reducing false reports.Notes
This is a breaking change. However, I personally could not think of any content inside math blocks that should be treated or checked as links or something. I also suspect there are other link-like patterns in math blocks that currently trigger unnecessary checks, and enabling the math extension should help avoid those as well.
If there is a reason why marksman has intentionally not enabled this extension so far, please feel free to close this PR.