Open
Conversation
nvnieuwk
reviewed
Mar 24, 2026
nvnieuwk
reviewed
Mar 24, 2026
| && !debug | ||
| ) { | ||
| try { | ||
| File launchDir = test.getLaunchDir(); |
Collaborator
There was a problem hiding this comment.
I'm not too familiar with this part of the code. Is launchDir the part where you execute nf-test from or the path where the test is executed from?
Author
There was a problem hiding this comment.
launchDir is the root of where the nf-test is launch from of the form .nf-test/tests/hash/
Collaborator
There was a problem hiding this comment.
Okay perfect! Thanks for the clarification
Co-authored-by: Nicolas Vannieuwkerke <101190534+nvnieuwk@users.noreply.github.com>
lukfor
reviewed
Mar 24, 2026
| assertEquals(0, exitCode); | ||
|
|
||
| } | ||
| }Expected test directories to exist without --no-save |
Collaborator
There was a problem hiding this comment.
Could you double check this?
Author
There was a problem hiding this comment.
Sorry for the mistake.
This is done.
Collaborator
|
LGTM. If the test case has been fixed, we can merge it. Thanks a lot! ✌️ |
Collaborator
|
Great. Thanks Louis! |
lukfor
approved these changes
Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduce the
--no-saveflag for thetestsubcommand.When a test is successfully ran, the launch directory is deleted to save disk space.
This should be particularly useful for small machine like github action runner.
Closes #298
Closes #315