feat: Improve support of hemertic toolchains with the clang tidy linter #597
+43
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.




The changes are more detailed in the commit messages.
In short, this adds two optional arguments to the linter:
gcc-install-dirarg to preventclang-tidyto use a gcc intallation from the host.depslets users actually provide the headers and files from an hermetic toolchain registered elsewhere using therules_ccAPI.both options were lifted from https://github.com/erenon/bazel_clang_tidy
Changes are visible to end-users: yes
Test plan
Would require registering an hermetic gcc toolchain, which is not trivial.
But manually:
x86-64--glibc--stable-2024.05-1.tar.xzfrom https://bootlin.com/ for example, see also https://github.com/bazelbuild/rules_cc/tree/main/examples/rule_based_toolchain/toolchains/gcc)gcc_install_diranddepsarguments to the label defined as follows (using the bootlin toolchain)clang-tidynow uses the hermetic headers.