Skip to content

Conversation

@arrdem
Copy link
Collaborator

@arrdem arrdem commented Aug 29, 2025

Tweak how we parse the exec_properties attribute so that the codepath is None-safe in case the user explicitly provided a None value somehow.

Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

Fixed #605.

Test plan

  • New test cases added

@aspect-workflows
Copy link

aspect-workflows bot commented Aug 29, 2025

test-os:linux-bzl:8 (Test)

⚠️ Buildkite build #906 failed.


test-os:linux-bzl:latest (Test)

⚠️ Buildkite build #906 failed.


test-os:linux-bzl:8 (Test)

e2e

⚠️ Buildkite build #906 failed.


test-os:linux-bzl:latest (Test)

e2e

⚠️ Buildkite build #906 failed.


test-os:linux-bzl:8 (Test)

examples/uv_pip_compile

All tests were cache hits

1 test (100.0%) was fully cached saving 335ms.


test-os:linux-bzl:latest (Test)

examples/uv_pip_compile

All tests were cache hits

1 test (100.0%) was fully cached saving 335ms.

@arrdem
Copy link
Collaborator Author

arrdem commented Nov 5, 2025

Redundant with #702.

@arrdem arrdem closed this Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: py_test / py_binary incorrectly handle an exec_properties attribute that is explicitly set to None

4 participants