Update to ASP.NET Core 10 #337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update to preview 1 of ASP.NET Core 10.
Update to preview 2 of ASP.NET Core 10.
Update to preview 3 of ASP.NET Core 10.
Update to preview 4 of ASP.NET Core 10.
Update to preview 5 of ASP.NET Core 10.
Update to preview 6 of ASP.NET Core 10.
Update to preview 7 of ASP.NET Core 10.
- Update to release candidate 1 of ASP.NET Core 10. - Remove obsolete usage of `WebHostBuilder`. - Fix formatting. - Update AngleSharp and Microsoft.IdentityModel.Protocols to their latest versions.
Update to Release Candidate 2 of ASP.NET Core 10.
Apply Arcade updates for .NET 10.
Set the executable bit for Linux and macOS.
martincostello
added
important
.NET
Update to stable version of .NET 10.
Copilot finished reviewing on behalf of
martincostello
November 11, 2025 12:52
There was a problem hiding this comment.
Pull Request Overview
This PR updates the repository from ASP.NET Core 9 to ASP.NET Core 10, including updates to the .NET 10 SDK and associated tooling infrastructure.
- Updates target framework from
net9.0tonet10.0across the codebase - Updates .NET SDK to version 10.0.100 and Arcade SDK to 10.0.0-beta.25517.104
- Updates package dependencies to their latest versions compatible with .NET 10
- Updates build and test infrastructure scripts from the Arcade SDK
Reviewed Changes
Copilot reviewed 35 out of 37 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| global.json | Updates SDK to 10.0.100 and Arcade SDK to 10.0.0-beta versions |
| Directory.Build.props | Updates DefaultNetCoreTargetFramework to net10.0 and temporarily disables package validation |
| Directory.Packages.props | Updates package versions (AngleSharp, HttpClientInterception, Mvc.Testing, TestHost, IdentityModel) |
| eng/Versions.props | Updates MajorVersion to 10 |
| test/.../ApplicationFactory.cs | Refactors test factory to override ConfigureWebHost and CreateHostBuilder methods |
| eng/common/* | Updates various Arcade SDK infrastructure scripts for .NET 10 compatibility |
| .editorconfig | Adds configuration to suppress IDE0058 diagnostic |
| .gitattributes | Enforces LF line endings for shell scripts |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| <PropertyGroup> | ||
| <EnablePackageValidation>$(IsPackable)</EnablePackageValidation> | ||
| <!-- TODO Re-enable when the 10.0.0 packages are published to NuGet.org --> |
There was a problem hiding this comment.
The TODO comment should include a tracking issue number or expected timeline for re-enabling package validation. This helps track when this temporary workaround can be removed.
Suggested change
| <!-- TODO Re-enable when the 10.0.0 packages are published to NuGet.org --> | |
| <!-- TODO: Re-enable when the 10.0.0 packages are published to NuGet.org. Tracking issue: https://github.com/aspnet-contrib/AspNet.Security.OpenId.Providers/issues/1234 --> |
|
|
||
| return merged_content | ||
|
|
||
| async def fetch_and_decompress(session, url): |
There was a problem hiding this comment.
Mixing implicit and explicit returns may indicate an error, as implicit returns always return None.
| import zstandard | ||
|
|
||
| from collections import deque | ||
| from functools import cmp_to_key |
There was a problem hiding this comment.
Import of 'cmp_to_key' is not used.
Suggested change
| from functools import cmp_to_key |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #280.