feat: Add #[ignore] macro
#139
Open
+206
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 18709095491Details
💛 - Coveralls |
epage
reviewed
Oct 22, 2025
Comment on lines
+58
to
+68
| #[libtest2::test] | ||
| #[ignore] | ||
| fn sheep(context: &libtest2::TestContext) -> libtest2::RunResult { | ||
| Err(libtest2::RunError::fail("got lost blindly following the flock")) | ||
| } | ||
| #[libtest2::test] | ||
| #[ignore = "slow"] | ||
| fn horse(context: &libtest2::TestContext) -> libtest2::RunResult { | ||
| Ok(()) | ||
| } |
There was a problem hiding this comment.
The tests are kept in sync with libtest2-mimic.
Could you have a commit before this one add these different cases in both sets of tests? This commit would just be about translated from the API to the attribute
epage
reviewed
Oct 22, 2025
epage
reviewed
Oct 22, 2025
epage
reviewed
Oct 22, 2025
epage
reviewed
Oct 22, 2025
|
Looks good minus the test organization issue, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #16.
After some discussion on #16 I went with the approach of accepting attributes following
#[test](for now only#[ignore]is accepted), as this would allow us to accept the standard syntax#[ignore = "some reason"](and later#[should_panic = "some expected message"]). These are not allowed in custom attributes, but so long as we don't emit these (only parse them internally) it's all good.