Skip to content

#701 word forms change in collect element issue#710

Merged
klues merged 4 commits intomasterfrom
#701-Word-forms-Change-in-collect-element-issue
Feb 9, 2026
Merged

#701 word forms change in collect element issue#710
klues merged 4 commits intomasterfrom
#701-Word-forms-Change-in-collect-element-issue

Conversation

@alexangelov14
Copy link
Collaborator

These are changes for issue #701

Updated as requested in issue #701
Now it will properly update the last added verb in the collect bar
@alexangelov14 alexangelov14 requested a review from klues December 17, 2025 22:58
@github-actions
Copy link

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/alexangelov14/-701-word-forms-change-in-collect-element-issue/pr

Copy link
Contributor

@klues klues left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍
Please see my comments.

@github-actions
Copy link

github-actions bot commented Jan 8, 2026

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/alexangelov14/-701-word-forms-change-in-collect-element-issue/pr

@alexangelov14
Copy link
Collaborator Author

@klues i added the changes requested in the second comment. You can check it out.

https://gridbeta-github.asterics-foundation.org/alexangelov14/-701-word-forms-change-in-collect-element-issue/pr

@alexangelov14
Copy link
Collaborator Author

@klues hello could you check the last changes whenever possible?

@github-actions
Copy link

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/alexangelov14/-701-word-forms-change-in-collect-element-issue/pr

@alexangelov14
Copy link
Collaborator Author

alexangelov14 commented Jan 23, 2026

@klues pushed changes regarding the element collection. Check it out if this is what you meant. To me personally changes the ux a bit with not showing the form of the word after pressing the '1.PERS' or '2.PERS' or whichever changing form on the button 'be' before having clicked it but if you think its more consistent then alright. Give it a look and tell me if its alright this way.

https://gridbeta-github.asterics-foundation.org/alexangelov14/-701-word-forms-change-in-collect-element-issue/pr

@alexangelov14
Copy link
Collaborator Author

@klues could you please check out the latest changes and give me some feedback if needed?

@klues
Copy link
Contributor

klues commented Feb 9, 2026

Thanks for your contribution, I'll merge.
@ms-mialingvo please quickly check if https://gridbeta-github.asterics-foundation.org/alexangelov14/-701-word-forms-change-in-collect-element-issue/pr still has the desired behaviour, just to be sure.

@klues
Copy link
Contributor

klues commented Feb 9, 2026

and sorry for the long time waiting for the reviews - just too much to do :/

@klues klues merged commit 789f171 into master Feb 9, 2026
1 check passed
@klues klues deleted the #701-Word-forms-Change-in-collect-element-issue branch February 9, 2026 10:25
@klues
Copy link
Contributor

klues commented Feb 9, 2026

@ms-mialingvo ok - quickly tested for myself and works as expected, so no real need that you test again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants