#701 word forms change in collect element issue#710
Conversation
Updated as requested in issue #701
Now it will properly update the last added verb in the collect bar
|
🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/alexangelov14/-701-word-forms-change-in-collect-element-issue/pr |
klues
left a comment
There was a problem hiding this comment.
Thanks! 👍
Please see my comments.
|
🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/alexangelov14/-701-word-forms-change-in-collect-element-issue/pr |
|
@klues i added the changes requested in the second comment. You can check it out. |
|
@klues hello could you check the last changes whenever possible? |
|
🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/alexangelov14/-701-word-forms-change-in-collect-element-issue/pr |
|
@klues pushed changes regarding the element collection. Check it out if this is what you meant. To me personally changes the ux a bit with not showing the form of the word after pressing the '1.PERS' or '2.PERS' or whichever changing form on the button 'be' before having clicked it but if you think its more consistent then alright. Give it a look and tell me if its alright this way. |
|
@klues could you please check out the latest changes and give me some feedback if needed? |
|
Thanks for your contribution, I'll merge. |
|
and sorry for the long time waiting for the reviews - just too much to do :/ |
|
@ms-mialingvo ok - quickly tested for myself and works as expected, so no real need that you test again. |
These are changes for issue #701