715/pictogram caching improvements by klues · Pull Request #744 · asterics/Asterics-AAC

klues · 2026-01-27T04:55:00Z

…sorigin attribute handling everywhere - needed to correctly fetch images and determine if they can be screenshotted for thumbnail or not

…l2canvas - better handling of images in screenshot generation

…k for extension, don't rely on request.destination, because html2canvas / html-to-image don't make image-destination requests

…quests to ensure that cache keys are matching later, using fixed pre-defined strategies, KNOWN_CORS_IMAGE_APIS to decide if a request is done in "cors" mode or not

… failed urls to back of current list and don't try again immediately, limit maximum tries, debounce saving current list to localStorage only every 5s

…atic build workflow

github-actions · 2026-01-27T04:56:36Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr

github-actions · 2026-01-27T05:01:56Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr

…s() are finished

…heck for constant also for clarity

github-actions · 2026-01-28T11:08:47Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr

…r current controller and prevent attaching a new event listener for each call to getController()

github-actions · 2026-01-28T11:31:33Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr

github-actions · 2026-01-28T12:18:07Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr

…for github workflow builds

…ilds

github-actions · 2026-01-28T13:05:08Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr

…onBar.vue

…er writes (or writes too late) in a long caching process

github-actions · 2026-02-19T09:25:45Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr

github-actions · 2026-02-19T09:56:11Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr

This reverts commit 5bd0209.

github-actions · 2026-02-19T10:30:49Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr

…in SW

github-actions · 2026-02-19T10:51:49Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr

github-actions · 2026-02-19T10:56:06Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr

… and workbox "CacheFirst" strategy. Cache both normal and opaque responses, use href as key and prevent any issues with header matching

github-actions · 2026-02-20T15:16:41Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr

…ng handling of cors requests for cached responses from SW?

github-actions · 2026-02-20T16:29:14Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr

github-actions · 2026-02-20T19:12:11Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr

…ossible to beta-release changes which aren't commited yet

…ts to prevent merge errors on stash apply,

…and ignore all other characteristics of the request (coming from img tag or from caching?!) - results in no errors for crossorigin=anonymous tags in iOS 13 / Safari, iOS 18 / Firefox

github-actions · 2026-02-25T08:43:52Z

🎉 Beta deployment successful!: view the changes in live preview environment: https://gridbeta-github.asterics-foundation.org/klues/715-pictogram-caching-improvements/pr

klues added 7 commits January 27, 2026 05:24

#715 moved element image to separate component in order to unify cros…

152df2f

…sorigin attribute handling everywhere - needed to correctly fetch images and determine if they can be screenshotted for thumbnail or not

#715 updated imageUtil.getScreenshot() to html-to-image, replaced htm…

74dd2d9

…l2canvas - better handling of images in screenshot generation

#715 updated methods when to cache images in serviceWorker - also loo…

86dd2bc

…k for extension, don't rely on request.destination, because html2canvas / html-to-image don't make image-destination requests

#715 updated caching logic - using strategy.handle() for pre-cache re…

16f290c

…quests to ensure that cache keys are matching later, using fixed pre-defined strategies, KNOWN_CORS_IMAGE_APIS to decide if a request is done in "cors" mode or not

#715 formatted some lines

3121984

#715 improved caching logic for images: track retries per image, move…

06de1dc

… failed urls to back of current list and don't try again immediately, limit maximum tries, debounce saving current list to localStorage only every 5s

#715 added way to force SW use via "serviceworker" tag on PR in autom…

30ca0f6

…atic build workflow

klues added the serviceworker label Jan 27, 2026

klues closed this Jan 27, 2026

klues reopened this Jan 27, 2026

klues added 2 commits January 28, 2026 12:03

#715 added waitUntil in SW to ensure clients.claim() and sendToClient…

e3f8e62

…s() are finished

#715 move cacheNext() to top to make it clearer it's always called, c…

c563e84

…heck for constant also for clarity

klues added 3 commits January 28, 2026 12:25

#715 added 15s wait loop until continue caching if offline

e0028e2

#715 use navigator.serviceWorker.ready promise to simplify waiting fo…

248c798

…r current controller and prevent attaching a new event listener for each call to getController()

#715 continue caching after a new SW activated

502e89a

#715 added missing return to actually pause caching if not online

37f5a51

klues added 3 commits January 28, 2026 13:58

#715 fixed SW to also work on other domains

3aeb557

#715 moved generation of SW paths to build step in order to also run …

b551a1d

…for github workflow builds

#715 changed base path to relative path to make it working in beta bu…

88b7a54

…ilds

klues added 5 commits January 28, 2026 14:19

#715 log message before timeout to display it directly

c6eb395

#715 made it possible to dynamically update infos shown in notificati…

77c76f5

…onBar.vue

#715 show image caching progress in notification bar

c5a617b

#715 use throttle for limiting writing to localstorage - debounce nev…

ac504ed

…er writes (or writes too late) in a long caching process

#715 removed logs

e342e17

#715 made getController() more robust

2aeefe2

klues added 2 commits February 19, 2026 10:54

#715 also intercept calls to log, not only console

b4b3b6f

#715 another try with getController(), with logs

89eb4fd

klues added 2 commits February 19, 2026 11:18

Revert "#715 added diagnostic version of SW for debugging"

84bfa7d

This reverts commit 5bd0209.

#715 just do skipWaiting always

7e8f5b8

klues added 2 commits February 19, 2026 11:48

#715 simplified SW activation, no message exchange, just skipWaiting …

b723586

…in SW

#715 removed debug logs

fdd0510

klues removed remote-debug labels Feb 19, 2026

klues closed this Feb 19, 2026

klues reopened this Feb 19, 2026

#715 simply use own caching logic instead of mix of own caching logic…

a8f1e96

… and workbox "CacheFirst" strategy. Cache both normal and opaque responses, use href as key and prevent any issues with header matching

#715 try to fix non-working images in collect element in iOS 13 - wro…

4f39390

…ng handling of cors requests for cached responses from SW?

#715 removed typo in src attribute

f724b0c

klues added 5 commits February 25, 2026 08:30

#715 renamed global error handling method

df00439

#715 for beta release: apply stashed changes before build - make it p…

7fae4ef

…ossible to beta-release changes which aren't commited yet

#715 for beta release: apply stashed changes before replacing constan…

810b6a0

…ts to prevent merge errors on stash apply,

#715 for beta release: also copy serviceWorkerCachePaths.js

03cf238

#715 fetch cors-mode first, fallback to no-cors; fetch only url.href …

136eaaf

…and ignore all other characteristics of the request (coming from img tag or from caching?!) - results in no errors for crossorigin=anonymous tags in iOS 13 / Safari, iOS 18 / Firefox

klues merged commit 6066da2 into master Feb 26, 2026
1 check passed

klues deleted the 715/pictogram-caching-improvements branch February 26, 2026 08:31

Conversation

klues commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 27, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

github-actions bot commented Jan 28, 2026

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

github-actions bot commented Feb 19, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 20, 2026

Uh oh!

github-actions bot commented Feb 25, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant