Access to NOIRLab Astro Data Archive

[weaverba137]

This PR supersedes #1701.

The initial commit simply restores the NOIRLab files to the state and content they were when #1701 was last worked on. Further work and testing will be needed to meet astroquery standards.

[weaverba137]

TO DO items identified (i.e. before even starting the review process):

• Proofread noirlab/noirlab.rst and verify examples.
• Remove telescope holdings from init file. These are certainly outdated. Link to the about page.
• Check required acknowledgment(s).
• Get remote tests working.
• Add non-remote tests to increase coverage, e.g. monkeypatch.

[codecov]

Codecov Report

Attention: Patch coverage is 96.90722% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.20%. Comparing base (82cab62) to head (708dbb4).
Report is 10 commits behind head on main.

Files with missing lines	Patch %	Lines
astroquery/noirlab/core.py	96.66%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3359      +/-   ##
==========================================
+ Coverage   70.07%   70.20%   +0.13%     
==========================================
  Files         232      234       +2     
  Lines       19893    19990      +97     
==========================================
+ Hits        13940    14034      +94     
- Misses       5953     5956       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[weaverba137]

Note to self: tox -e py310-test-online -- -P noirlab to do remote tests on only astroquery.noirlab.

[bsipocz]

You also need -R to run the remote tests

[weaverba137]

@keflavich @bsipocz this is ready for first-pass review.

I'm having some trouble with the doc build:

reading sources... [100%] xmatch/xmatch

/home/docs/checkouts/readthedocs.org/user_builds/astroquery/checkouts/3359/docs/noirlab/noirlab.rst:171: CRITICAL: Title level inconsistent:

astroquery.noirlab Package
-------------------------- [docutils]
/home/docs/checkouts/readthedocs.org/user_builds/astroquery/checkouts/3359/docs/noirlab/noirlab.rst:176: CRITICAL: Title level inconsistent:

Classes
^^^^^^^ [docutils]
looking for now-outdated files... none found

I've tried to set up the title levels similar to other packages, such as sdss.

I'm also looking for advice on whether further application of async_to_sync is needed.

[weaverba137]

PS, the .retrieve() method needs further testing. In the previous PR, this method actually returned a HDUList rather than a filename or file object. Could you please advise on how this should be handled in line with similar astroquery methods?

[bsipocz]

Thanks. I need to get back to the ESO review first, but put this on the list now, too.