Skip to content

Conversation

xeho91
Copy link

@xeho91 xeho91 commented Jul 29, 2025

Description

  • Removed node-fetch and @types/node-fetch dependencies
  • Those dependencies were used only for the types, AFAIK.
    I'm unsure what the minimum Node.js version supported for this package is. I noticed in the package root >=18.
    It could create a debate whether this update is a breaking change (requires major upgrade) or not.
    I personally don't think so, given that I solved only the typing issue.

Related issue(s)

Package @types/node-fetch has a critical vurnerable dependency form-data: GHSA-fjxv-7rqg-78g4

Copy link

changeset-bot bot commented Jul 29, 2025

🦋 Changeset detected

Latest commit: 7578dc3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@asyncapi/parser Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

@xeho91 xeho91 changed the title refactor: Remove node-fetch dependency refactor: remove node-fetch dependency Jul 29, 2025
@xeho91
Copy link
Author

xeho91 commented Jul 30, 2025

Note

There's a chance that browserify-shims dev dependency is no longer needed

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant