Skip to content

Conversation

@Pakisan
Copy link
Member

@Pakisan Pakisan commented Aug 8, 2025

New binding must trigger new release. It means MUST be included in 3.1.0

Sorry, my bad, merged too fast 😞

Reverts #582

@sonarqubecloud
Copy link

sonarqubecloud bot commented Aug 8, 2025

@Pakisan Pakisan changed the title Revert "feat: add ros2 bindings" revert: feat: add ros2 bindings Aug 8, 2025
@Pakisan
Copy link
Member Author

Pakisan commented Aug 8, 2025

@derberg @jonaslagoni

Copy link
Member

@derberg derberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries mate

@Pakisan Pakisan merged commit d096d0f into master Aug 9, 2025
25 of 26 checks passed
@Pakisan Pakisan deleted the revert-582-master branch August 9, 2025 12:22
Copy link
Member

derberg commented Aug 9, 2025

one more detail, revert: is not triggering a release, so it is still there in the package. You would need to trigger a release, in the past we solved it by adding a PR with feat: and empty commit

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 6.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants