Write a few unit-tests for babel plugin#1648
Write a few unit-tests for babel plugin#1648yamadapc wants to merge 6 commits intoatlassian-labs:masterfrom
Conversation
yamadapc
requested review from
JakeLane,
dddlr,
liamqma and
pancaspe87
as code owners
|
Co-authored-by: Grant Wong <2908767+dddlr@users.noreply.github.com>
| } as any; | ||
|
|
||
| const { css, variables } = buildCss(path!.node, meta); | ||
| // TODO: This should not happen |
There was a problem hiding this comment.
isn't this a bug? i'm not sure why we're adding a test case to enforce buggy behaviour here - perhaps creating a github issue would be better than having this test case here, as the former is more easily discoverable (we don't really check back on test cases unless they get broken)
the other test cases in this file look great, thank you for adding them 🙌
(sorry, had a meeting earlier so i couldn't review the whole PR at once)
There was a problem hiding this comment.
Sure, let me remove some of these; generally I'm only trying to reproduce bugs with these.
It's a bit of a structural issue regarding what css + cssMap APIs do.
| @@ -0,0 +1,63 @@ | |||
| import { parse } from '@babel/parser'; | |||
4 participants
No description provided.