Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #693 to create a more cohesive context system for execution.
Previously we
NadelExecutionContext
one for every call toNadel.execute
NadelServiceExecutionContext
one for every call toNextgenEngine.executeTopLevelField
NadelTransformServiceExecutionContext
one for every transform per operation execution.NadelTransform.State
one for every field that the transform runs on.So now we have
NadelExecutionContext
one for every call toNadel.execute
NadelOperationExecutionContext
one for every call toNextgenEngine.executeTopLevelField
NadelTransformOperationContext
one for every transform per operation execution.NadelTransformFieldContext
one for every field that the transform runs on.So these classes were renamed
NadelServiceExecutionContext
→NadelOperationExecutionContext
NadelTransformServiceExecutionContext
→NadelTransformOperationContext
NadelTransform.State
→NadelTransformFieldContext
Some other renames
NadelTransform.isApplicable
->NadelTransform.getTransformFieldContext
NadelTransform.buildContext
->NadelTransform.getTransformOperationContext
Each of the contexts has a reference to the parent context, so we have a good way to reference objects from upper portions of execution e.g. can do
transformFieldContext.executionContext.engineSchema
etc.This has a good benefit in that our
NadelTransform
class is much simplervs