Open
Conversation
giuliostramondo
requested review from
Pantani,
giunatale,
julienrbrt and
tbruyelle
as code owners
|
@giuliostramondo your pull request is missing a changelog! |
giuliostramondo
changed the title
tbruyelle
reviewed
Jan 5, 2026
| @@ -0,0 +1,18 @@ | |||
| syntax = "proto3"; | |||
|
|
|||
| package cosmos.dynamicfee.module.v1; | |||
Collaborator
There was a problem hiding this comment.
So if we change the proto path, which sounds legit, we'll break again the API.
Fortunately it should not be widely used, but there's a pending PR on Hermes that will need to be updated (even though it will never be merged, let's be honest...)
giuliostramondo
force-pushed
the
giuliostramondo/chore/dynamicfee-sdk
branch
from
cbfeec5 to
56a7d33
Compare
julienrbrt
approved these changes
Jan 16, 2026
giunatale
approved these changes
Jan 19, 2026
Pantani
reviewed
Jan 22, 2026
giuliostramondo
force-pushed
the
giuliostramondo/chore/dynamicfee-sdk
branch
from
352f5ba to
2a6fb4a
Compare
Pantani
approved these changes
Jan 26, 2026
giuliostramondo
force-pushed
the
giuliostramondo/chore/dynamicfee-sdk
branch
from
2a6fb4a to
dc057b0
Compare
giunatale
reviewed
Feb 2, 2026
Co-authored-by: Giuseppe Natale <12249307+giunatale@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.