ci: don't use HTTPS for VSwitch test - #397
Merged
Merged
Conversation
The NTP is flaky sometimes and is out of our control. So when the VM fails to set the date and time, HTTPS won't work and the download tests will fail due to factors out of our control. Which is quite annoying. So let's just do HTTP download like before, but I'll leave the automatic date and time setting via NTP in still. Signed-off-by: Bill Nguyen <bill.nguyen@unsw.edu.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I forgot about the VSwitch in #396.
The NTP is flaky sometimes and is out of our control. So when the VM fails to set the date and time, HTTPS won't work and the download tests will fail due to factors out of our control. Which is quite annoying.
So let's just do HTTP download like before, but I'll leave the automatic date and time setting via NTP in still.