-
Notifications
You must be signed in to change notification settings - Fork 27
Add pinctrl driver for imx8-based platforms #426
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| from sdfgen import SystemDescription, Sddf, DeviceTree | ||
| from importlib.metadata import version | ||
|
|
||
| # @billn fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dreamliner787-9 sort out once au-ts/microkit_sdf_gen#14 is merged
7d83693 to
8e5429a
Compare
…f pinctrl Signed-off-by: Bill Nguyen <[email protected]>
Signed-off-by: Bill Nguyen <[email protected]>
Courtney3141
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good first implementation. Needs to be rebased and ensure all docs files have line length < 100 chars.
f25b16b to
ebc332d
Compare
Signed-off-by: Bill Nguyen <[email protected]>
ebc332d to
3873a3f
Compare
Courtney3141
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only remaining change not mentioned (that I think we should do something about) is the Python devicetree module.
Signed-off-by: Bill Nguyen <[email protected]>
Signed-off-by: Bill Nguyen <[email protected]>
Signed-off-by: Bill Nguyen <[email protected]>
Signed-off-by: Bill Nguyen <[email protected]>
3873a3f to
7691c5b
Compare
| * Copyright 2025, UNSW | ||
| * SPDX-License-Identifier: BSD-2-Clause | ||
| */ | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see this is approved already, but is this example meant to have been replaced with something new? This doesn't appear to do anything with pinctrl just yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just copied the serial example to demonstrate how you can compile the pinctrl driver as we don't have any drivers for the IMX platform that requires pinctrl configuration yet (afaik).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's fair enough, although it would definitely be good to somehow have an example that specifically shows that the pinctrl driver works so we can use it for CI. Is it possible to write an example that does something like assign a constant value to an output pin? E.g. connect a voltage line -> GPIO pin. (contrived, ik).
It would be strongly preferable if something like that can happen so that we can always narrow the failing example back to pinctrl instead of also needing to wonder if the associated driver class is the issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did thought of that when I cloned the serial example. But since this driver doesn't support dynamic pinctrl configuration (yet). We would have to bundle an edited device tree with the example then explain where things differ. Which I thought was more complicated than necessary when serial is the most basic of devices that should work. Plus if the pinctrl driver is broken, it would break the "pinctrl" example rather than the "serial" example so we can always narrow down any failures.
We can revisit implementing your idea once the driver supports dynamic pinctrl reconfiguration?
This PR adds implmentation and documentations of the pinctrl subsystem and driver for imx8-based platforms.
Limitations:
Checklist before we can merge this: