Support PHP 8.5

[compwright]

Method SplObjectStorage::attach() is deprecated since PHP 8.5.

Summary by CodeRabbit

• Refactor
  • Optimized internal data storage mechanism for improved efficiency.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Replaced SplObjectStorage::attach() method call with array-style offset syntax for storing initial data in GenericType.php. The change maintains identical functionality while using an alternative storage mechanism.

Changes

Cohort / File(s)	Summary
SplObjectStorage refactoring src/Type/GenericType.php	Replaced $this->initial_data->attach($entity, $initial_data) with $this->initial_data[$entity] = $initial_data for functionally equivalent data storage.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

• Straightforward syntax substitution with no behavioral changes
• No API modifications or control flow alterations

Poem

🐰 A storage shift so clean and bright,
From attach() calls to brackets right,
Same data flows through object's keep,
Refactored smooth—a rabbit's leap! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title 'Support PHP 8.5' is overly broad and does not clearly reflect the actual change, which is replacing SplObjectStorage::attach() with array-style offsetSet syntax in a single file.	Use a more specific title that describes the actual code change, such as 'Replace SplObjectStorage::attach() with array-style offset assignment' or 'Update GenericType to use array syntax for SplObjectStorage'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

Tip

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

• Provide your own instructions using the high_level_summary_instructions setting.
• Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).
• Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

1. 📝 Description — Summarize the main change in 50–60 words, explaining what was done.
2. 📓 References — List relevant issues, discussions, documentation, or related PRs.
3. 📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.
4. 📊 Contributor Summary — Include a Markdown table showing contributions:
   | Contributor | Lines Added | Lines Removed | Files Changed |
5. ✔️ Additional Notes — Add any extra reviewer context.
   Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 93df892 and 3c3348c.

📒 Files selected for processing (1)

• src/Type/GenericType.php (1 hunks)