[AIDX-323] Rename all ciba/token vault methods for node js #16
Conversation
| ); | ||
|
|
||
| return ( | ||
| <ChatWindow |
There was a problem hiding this comment.
why this change? seems unrelated and unnecessary
unfortunately, i think this change will soon require some of the langgraph + ai sdk 5 updates as well (w/ these core package updates coming). Preference here is to do at once, since these examples have not yet been updated, and so we do not have to re-test all of these twice / re-update the public documentation separately. We cut separate tags for those in the automated JS release, but i don't think we are planning to do this in the python. Agree it would have been cleaner git history here to isolate, but this is a bigger effort then. These changes should not be overly significant though, and similar examples have been validated to work previously in the auth0-ai-js / auth0-ai-python repos though. |
There was a problem hiding this comment.
This file, sibling files and directory name should be identical to the contents of the packages/ai-components/templates/TokenVault/* directory from your PR at: auth0-lab/auth0-ai-js#285
This repo seems to hold a old version of the component and is a bit confusing. For example, the FederatedConnectionInterruptHandler does not belong as part of this component and should be moved out.
This same comment applies to all other samples below in the PR 👇
There was a problem hiding this comment.
+1 here, was noting the same recently in auth0-assistant0 repo. We seem to have different variations of this component, so i would agree w/ moving it out to another directory that is more local to the usage for now.
Renamed all CIBA and Token Vault-related methods/classes in our AI JS SDK
According to name convention docs