Skip to content

Conversation

amenomori-wn
Copy link
Contributor

@amenomori-wn amenomori-wn commented Jul 15, 2025

🔧 Changes

Enhanced the updateConnectionEnabledClients function to support updating more than 50 enabled clients for a connection. This change addresses the Auth0 API limitation of processing only 50 clients per request by automatically splitting larger arrays into multiple API calls.

🔬 Testing

  1. Create a database with more than 50 clients enabled in a config.yml or json.
  2. Run the deployment tool and verify all clients are properly enabled.

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

@amenomori-wn amenomori-wn requested a review from a team as a code owner July 15, 2025 07:48
@kushalshit27
Copy link
Contributor

Thank you for submitting this PR! Your contribution is greatly appreciated. We'll review it shortly

@kushalshit27
Copy link
Contributor

Hi, @amenomori-wn

Thank you for submitting this PR! I really appreciate the time and effort you put into it.

I have two small suggestions:

Let me know if you have any questions. Looking forward to your updates!

Copy link
Contributor

@kushalshit27 kushalshit27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a unit test covering this code update.

@amenomori-wn amenomori-wn force-pushed the feature/paginate-database-enabled-clients-import branch from 1aed686 to e8bfa1b Compare July 17, 2025 10:04
@kushalshit27 kushalshit27 requested a review from Copilot July 18, 2025 06:40
Copilot

This comment was marked as outdated.

Copy link
Contributor

@kushalshit27 kushalshit27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kushalshit27 kushalshit27 merged commit ebf361c into auth0:master Jul 18, 2025
7 of 8 checks passed
@kushalshit27 kushalshit27 mentioned this pull request Jul 30, 2025
@kushalshit27
Copy link
Contributor

kushalshit27 commented Jul 30, 2025

Hi, @amenomori-wn
This is released in version 8.12.0. Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants