Skip to content

Conversation

@kushalshit27
Copy link
Contributor

@kushalshit27 kushalshit27 commented Nov 7, 2025

🔧 Changes

This PR addresses the issue where the directory format parser required bot-detection.json and captcha.json files to exist in the attack-protection/ directory, causing deployments to fail.

📚 References

🔬 Testing

  • Manual Testing

📝 Checklist

  • All new/changed/fixed functionality is covered by tests (or N/A)
  • I have added documentation for all new/changed functionality (or N/A)

…calls

- src/tools/auth0/handlers/attackProtection.ts: simplify update calls for bot detection, captcha, and other configurations
…detection and captcha loading logic

- src/context/directory/handlers/attackProtection.ts: refactor to check if bot detection and captcha files exist before loading
- src/context/yaml/handlers/attackProtection.ts: rename parseAndDump to separate parse and dump functions
@kushalshit27 kushalshit27 requested a review from a team as a code owner November 7, 2025 03:27
@kushalshit27 kushalshit27 changed the title Fix bot detection and captcha files optional loading & CIDR validation fix: bot detection and captcha files optional loading & CIDR validation Nov 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.07%. Comparing base (1914ea2) to head (4ebec06).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/context/directory/handlers/attackProtection.ts 58.82% 0 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1200      +/-   ##
==========================================
- Coverage   80.11%   80.07%   -0.04%     
==========================================
  Files         134      134              
  Lines        5285     5290       +5     
  Branches     1076     1079       +3     
==========================================
+ Hits         4234     4236       +2     
  Misses        590      590              
- Partials      461      464       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kushalshit27 kushalshit27 merged commit 86de11d into master Nov 10, 2025
7 checks passed
@kushalshit27 kushalshit27 deleted the DXCDT-1261-bot-detection-support-cidr-fix branch November 10, 2025 05:07
@kushalshit27 kushalshit27 mentioned this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bot Detection & Captcha are breaking builds.

4 participants