Skip to content

#483 Quick fix to add hashPasswordForCookie to Guard.#484

Closed
steffjenl wants to merge 3 commits intoauth0:mainfrom
steffjenl:main
Closed

#483 Quick fix to add hashPasswordForCookie to Guard.#484
steffjenl wants to merge 3 commits intoauth0:mainfrom
steffjenl:main

Conversation

@steffjenl
Copy link
Copy Markdown

Changes

Add missing hashPasswordForCookie function in AuthenticationGuard

References

#483
laravel/framework@b5f9532

Testing

Contributor Checklist

@steffjenl steffjenl requested a review from a team as a code owner January 15, 2026 11:11
@talkinnl
Copy link
Copy Markdown

talkinnl commented Jan 16, 2026

Yesterday, Laravel merged a fix to fallback to the old insecure behavior if the method is missing: laravel/framework#58385

I think this laravel-auth0 PR should still be merged: Not doing so enables Laravel to run in the old unsafe way of storing too much password details in cookies. Merging this removes a liability, and strengthens the Auth0 USP as being more secure.

@steffjenl steffjenl changed the title #483 Quick and dirty fix to add hashPasswordForCookie to Guard. #483 Quick fix to add hashPasswordForCookie to Guard. Jan 16, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 8, 2026

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.47%. Comparing base (09cc9ac) to head (15eb969).
⚠️ Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
src/Guards/AuthenticationGuard.php 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #484      +/-   ##
============================================
- Coverage     99.92%   99.47%   -0.45%     
- Complexity      538      539       +1     
============================================
  Files            31       31              
  Lines          1340     1346       +6     
============================================
  Hits           1339     1339              
- Misses            1        7       +6     
Flag Coverage Δ
unittestsvalidate 99.47% <0.00%> (-0.45%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kishore7snehil
Copy link
Copy Markdown
Contributor

This has been released in v7.22.0.

@steffjenl Thanks for raising this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants