Laravel 13 compatibility

[cosmastech]

Changes

Update composer requirements to support Laravel 13.

References

Testing

Contributor Checklist

• I have read the Auth0 general contribution guidelines
• I have read the Auth0 code of conduct

[hari-euka]

Can we please look into merging this as its becoming a blocker for our Laravel 13 upgrade.

[mattystowe]

as @hari-euka mentioned - this is a blocker to Laravel 13 upgrade and we would really appreciate this being approved and merged asap. Many thanks!

[hari-euka]

Hey @kishore7snehil can you please check this PR, so we will be able to upgrade to Laravel 13, seems like a lot of people are waiting on this.

[cosmastech]

@kishore7snehil I think I got everything you requested. 🙇

[hari-euka]

Hey @kishore7snehil can we pls have this sorted? Many thanks.

[kishore7snehil]

Same issue as r3008

[kishore7snehil]

👋 @hari-euka , We are planning a minor release in the coming few days (before Friday), so I can include this in the same. If by any chance that release is cancelled or pushed, I'll cut a separate release by Thursday.

cc: @cosmastech

[hari-euka]

Thank you @kishore7snehil & @cosmastech

[sergix44]

I would also test for php 8.4 and 8.5, especially since laravel 13 requires 8.3 at minimum, up to 8.5.

This is an error I'm getting on php 8.5, when trying to use your branch @cosmastech

... dependencies download ...
Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi

   ErrorException 

  Cannot bind an instance to a static closure, this will be an error in PHP 9

  at vendor/laravel/framework/src/Illuminate/Auth/AuthManager.php:274
    270▕      * @return $this
    271▕      */
    272▕     public function extend($driver, Closure $callback)
    273▕     {
  ➜ 274▕         $this->customCreators[$driver] = $callback->bindTo($this, $this);
    275▕ 
    276▕         return $this;
    277▕     }
    278▕ 

      +9 vendor frames 

  10  [internal]:0
      Illuminate\Foundation\Application::{closure:Illuminate\Foundation\Application::boot():1131}(Object(Auth0\Laravel\ServiceProvider), "Auth0\Laravel\ServiceProvider")
      +5 vendor frames 

  16  artisan:35
      Illuminate\Foundation\Console\Kernel::handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))

Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 1

Seems because all these closures are declared as static:
https://github.com/auth0/laravel-auth0/blob/main/src/ServiceProviderAbstract.php#L37

[cosmastech]

I would also test for php 8.4 and 8.5, especially since laravel 13 requires 8.3 at minimum, up to 8.5.

This is an error I'm getting on php 8.5, when trying to use your branch @cosmastech

... dependencies download ...
Generating optimized autoload files
> Illuminate\Foundation\ComposerScripts::postAutoloadDump
> @php artisan package:discover --ansi

   ErrorException 

  Cannot bind an instance to a static closure, this will be an error in PHP 9

  at vendor/laravel/framework/src/Illuminate/Auth/AuthManager.php:274
    270▕      * @return $this
    271▕      */
    272▕     public function extend($driver, Closure $callback)
    273▕     {
  ➜ 274▕         $this->customCreators[$driver] = $callback->bindTo($this, $this);
    275▕ 
    276▕         return $this;
    277▕     }
    278▕ 

      +9 vendor frames 

  10  [internal]:0
      Illuminate\Foundation\Application::{closure:Illuminate\Foundation\Application::boot():1131}(Object(Auth0\Laravel\ServiceProvider), "Auth0\Laravel\ServiceProvider")
      +5 vendor frames 

  16  artisan:35
      Illuminate\Foundation\Console\Kernel::handle(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))

Script @php artisan package:discover --ansi handling the post-autoload-dump event returned with error code 1

Seems because all these closures are declared as static: https://github.com/auth0/laravel-auth0/blob/main/src/ServiceProviderAbstract.php#L37

Great callout! Thanks.

[stegeto22]

Should PHP 8.4 and 8.5 be added to .github/workflows/matrix.json? And 8.2 could be removed.

[sergix44]

Should PHP 8.4 and 8.5 be added to .github/workflows/matrix.json? And 8.2 could be removed.

I dont think 8.2 should be removed (since its still supporting laravel 12) but add 8.4 and 8.5 for sure

[kishore7snehil]

I dont think 8.2 should be removed (since its still supporting laravel 12) but add 8.4 and 8.5 for sure

@cosmastech Are you planning to add these versions in the CI matrix? Also please take a look at failing UTs.

[cosmastech]

I dont think 8.2 should be removed (since its still supporting laravel 12) but add 8.4 and 8.5 for sure

@cosmastech Are you planning to add these versions in the CI matrix? Also please take a look at failing UTs.

Working on it now. Thanks!

[cosmastech]

There is an issue with psalm 6 (which is required for php 8.4)

Looking into this.

[cosmastech]

@kishore7snehil There's an issue with psalm 6. It does not like the MixedInferredReturnType (apparently this was removed from 5 -> 6)

When I remove it and run psalm:fix, we get a giant diff and many of the changes I don't think are appropriate for a patch release.

That said... I notice this project has both psalm and phpstan. Is there a reason that both are needed?

Unless I'm not expected to run psalter? That appears to fix things that aren't flagged as errors by psalm.

[kishore7snehil]

Thanks @cosmastech for the contribution and the follow-up fixes!

I've taken all your commits and resolved the remaining CI issues (capped Psalm to <6.5 due to a PHP version mismatch on the CI runner, and disabled the static_lambda CS Fixer rule since AuthManager::extend() uses bindTo()).

PR #491 is up with everything included. Appreciate the help from @hari-euka , @sergix44 and @stegeto22 as well.

[kishore7snehil]

@cosmastech Please feel free to close this PR. The support has been released in v7.22.0.