-
Notifications
You must be signed in to change notification settings - Fork 254
Backport Proof of Space perf improvements from abundance #3712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…ace (nazar-pc/abundance#406) Using the entire ab-proof-of-space as at commit: nazar-pc/abundance@6d56b48 And merge changes from ab-proof-of-space/Cargo.toml into subspace-proof-of-space/Cargo.toml.
Using the entire ab-chaha8 as at commit: nazar-pc/abundance@6d56b48
🛡️ Immunefi PR ReviewsWe noticed that your project isn't set up for automatic code reviews. If you'd like this PR reviewed by the Immunefi team, you can request it manually using the link below: Once submitted, we'll take care of assigning a reviewer and follow up here. |
The benchmark failure might take some time to fix, and I've run out of time today. Looks like the benchmarks expect Proof of Space to return Ok, but instead it's returning an error. The "check individually" failure is trivial, just some missing dead code annotations. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that miri
annotations may not be necessary since this repo doesn't run tests under Miri (abundance does to have additional guarantees that unsafe
code maintains invariants, but some tests are too slow to run regularly in CI or impractical to run in general, hence corresponding annotations).
Similarly no-panic
ensures compiler can figure out the code can't possibly panic at compile time, which allows for better optimizations, but this repo doesn't run corresponding tests, so not sure how useful it is to port over.
This PR backports the latest compatible Proof of Space changes from abundance, including some API refactors, including all relevant files up until commit:
nazar-pc/abundance@6d56b48
It should be reviewed one commit at a time.
The copied code is best reviewed by:
The copied code includes:
Various minor fixes are then made to get it to compile and pass CI:
Cargo.toml
build filesCode contributor checklist: