feat: add run_in_parallel method and tests

[LucasAlvws]

Pull Request

Description

Related Issue(s)

Type of Change

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Documentation update
• Refactoring (no functional changes, no API changes)
• Performance improvement
• Tests (adding missing tests or correcting existing tests)
• Build or CI/CD related changes

How Has This Been Tested?

# Include code examples if relevant

Testing Checklist

• Unit tests added/updated
• Integration tests added/updated
• All existing tests pass

Screenshots

Implementation Details

API Changes

Additional Info

Checklist before requesting a review

• My code follows the style guidelines of this project
• I have performed a self-review of my code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• My changes generate no new warnings
• I have added tests that prove my fix is effective or that my feature works
• New and existing unit tests pass locally with my changes
• I have run poetry run task lint and fixed any issues
• I have run poetry run task test and all tests pass
• My commits follow the conventional commits style

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[thalissonvs]

A property would be better for this logic:

    @property
    def _semaphore(self) -> asyncio.Semaphore | None:
        if not self.options.max_parallel_tasks:
            return None
        
        # this is lazy
        if self._sem_instance is None:
            self._sem_instance = asyncio.Semaphore(self.options.max_parallel_tasks)
        
        return self._sem_instance

[thalissonvs]

a cached property is also really great for this case:

    @cached_property
    def _semaphore(self) -> asyncio.Semaphore | None:
        if not self.options.max_parallel_tasks:
            return None
        return asyncio.Semaphore(self.options.max_parallel_tasks)

[thalissonvs]

this lock is unecessary since the creation of the semaphore is sync. The GIL will take care of it, so you can remove all the logic for the lock

[thalissonvs]

you can remove most of the comments, try to keep only the really necessary ones.
we can add more information about this in the documentation

[thalissonvs]

for the typing, a generic would be great:

T = TypeVar("T")

async def run_in_parallel(self, *coroutines: Coroutine[Any, Any, T]) -> list[T]: ...

that way, the return type of the coroutines will be reflected directly in the return type of the method:

async def get_number() -> int: ...
async def get_text() -> str: ...

# here, T will be resolved as Union[int, str]
results = await browser.run_in_parallel(get_number(), get_text())

# results will be resolved to list[str | int]

[LucasAlvws]

so i can just add T = TypeVar("T") in the TYPE_CHECKING nested imports?

[LucasAlvws]

or should i add it just before the class Browser like the logger = logging.getLogger(name)

[thalissonvs]

I'm not sure, but i think it can be under the if TYPE_CHECKING, just remember to import annotations:

from future import __annotations__

[thalissonvs]

I usually like to put the properties in the top of the class, can you do that?

[thalissonvs]

some logs would also be great, try to keep most of them as debug