fix: solving start tab not applying browsers preferences properly#346
Open
LucasAlvws wants to merge 2 commits intoautoscrape-labs:mainfrom
Open
fix: solving start tab not applying browsers preferences properly#346LucasAlvws wants to merge 2 commits intoautoscrape-labs:mainfrom
LucasAlvws wants to merge 2 commits intoautoscrape-labs:mainfrom
Conversation
LucasAlvws
force-pushed
the
start_tab_issue
branch
from
f27c7f0 to
4ee2673
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
thalissonvs
reviewed
Jan 22, 2026
Comment on lines
+197
to
201
| self._tabs_opened[valid_tab_id] = initial_tab | ||
| await initial_tab.close() | ||
| tab: Tab = await self.new_tab() | ||
| logger.info('Initial tab attached') | ||
| return tab |
Member
There was a problem hiding this comment.
you assigned the initial_tab to the tabs_opened dict, it can cause some conflicts
Collaborator
Author
There was a problem hiding this comment.
I can remove it, but I dont think that has any problem, because the tab.close() remove pop the valid_tab_id from tabs_opened. What you think? "self._tabs_opened[valid_tab_id] = initial_tab" this line was already in the code before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Related Issue(s)
Type of Change
How Has This Been Tested?
# Include code examples if relevantTesting Checklist
Screenshots
Implementation Details
API Changes
Additional Info
Checklist before requesting a review
poetry run task lintand fixed any issuespoetry run task testand all tests pass