Skip to content

Conversation

traversaro
Copy link
Contributor

Description

As uuid_helper.hpp uses uint8_t type, it should include the cstdint header, see https://en.cppreference.com/w/cpp/types/integer.html .

How was this PR tested?

By compiling the project.

Notes for reviewers

None.

Effects on system behavior

None.

Copy link

github-actions bot commented Jul 5, 2025

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@traversaro
Copy link
Contributor Author

xref: RoboStack/ros-humble#320

Copy link
Contributor

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@traversaro thanks! We check DCO for every commit (like ROS does), could you amend your commit so that it includes your signature? Thanks.

@traversaro
Copy link
Contributor Author

@traversaro thanks! We check DCO for every commit (like ROS does), could you amend your commit so that it includes your signature? Thanks.

Sure! Just FYI I am not sure you are aware that DCO can be required at the GitHub level (see https://docs.github.com/en/organizations/managing-organization-settings/managing-the-commit-signoff-policy-for-your-organization or https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/managing-repository-settings/managing-the-commit-signoff-policy-for-your-repository), that has the advantage that web ui commits automatically have Signed-off . If I recall correctly, that setting is enabled in both ros2 and gazebosim organizations.

@wep21 wep21 changed the title autoware_utils_uuid: Include cstdint as uint8_t is used fix(autoware_utils_uuid): include cstdint as uint8_t is used Jul 5, 2025
Copy link

codecov bot commented Jul 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@eee0b7b). Learn more about missing BASE report.

Additional details and impacted files
@@          Coverage Diff           @@
##             main     #79   +/-   ##
======================================
  Coverage        ?   0.95%           
======================================
  Files           ?      76           
  Lines           ?    3445           
  Branches        ?     361           
======================================
  Hits            ?      33           
  Misses          ?    3407           
  Partials        ?       5           
Flag Coverage Δ
differential 0.95% <ø> (?)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wep21 wep21 merged commit 2fe987a into autowarefoundation:main Jul 5, 2025
16 of 18 checks passed
@esteve
Copy link
Contributor

esteve commented Jul 5, 2025

@traversaro I didn't know about that, that's really cool, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants