feat: support custom VM IDs in create-l1 and Ansible#8
Open
owenwahlgren wants to merge 1 commit intomainfrom
Open
feat: support custom VM IDs in create-l1 and Ansible#8owenwahlgren wants to merge 1 commit intomainfrom
owenwahlgren wants to merge 1 commit intomainfrom
Conversation
Add `--vm-id` flag to the create-l1 tool so it can deploy chains with any AvalancheGo VM plugin, not just SubnetEVM. Also add Ansible support for installing custom VM plugin binaries on validator nodes. Changes: - tools/create-l1/main.go: Add --vm-id flag, parse with ids.FromString, pass to IssueCreateChainTx instead of hardcoded constants.SubnetEVMID - ansible/roles/avalanchego/defaults/main.yml: Add custom_vm_id and custom_vm_binary_path variables - ansible/roles/avalanchego/tasks/main.yml: Add task to copy custom VM binary to the plugins directory when variables are set Closes #7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--vm-idflag totools/create-l1so it can deploy chains with any AvalancheGo VM plugin, not just SubnetEVMMotivation
The create-l1 tool currently hardcodes
constants.SubnetEVMID. This makes it impossible to deploy custom VMs (DAML VM, MoveVM, etc.) without forking the tool. This PR makes the VM ID configurable while keeping SubnetEVM as the default.Changes
tools/create-l1/main.go: Add--vm-idflag, parse withids.FromString(), pass toIssueCreateChainTxansible/roles/avalanchego/defaults/main.yml: Addcustom_vm_idandcustom_vm_binary_pathvariablesansible/roles/avalanchego/tasks/main.yml: Add task to copy custom VM binary to plugins directoryUsage
Test plan
go buildcompiles with no errors--vm-idomitted)IssueCreateChainTxCloses #7