Console: ERC20 and Native Token Staking Manager Setup + Operations
#2880
+5,509
−70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…uilders-hub into console/staking-manager-setup
owenwahlgren
changed the title
Console: ERC20 and Native Token Staking Manager Setup
owenwahlgren
changed the title
Console: ERC20 and Native Token Staking Manager SetupConsole: ERC20 and Native Token Staking Manager Setup + Operations
owenwahlgren
added
the
DO NOT MERGE
| } | ||
|
|
||
| export function ValidatorsList({ validators, onChange, l1TotalInitializedWeight = null, userPChainBalanceNavax = null }: Props) { | ||
| export function ValidatorsList({ validators, onChange, l1TotalInitializedWeight = null, userPChainBalanceNavax = null, hideConsensusWeight = false }: Props) { |
There was a problem hiding this comment.
do we default to false because you can only go from PoA to PoS?
| }); | ||
|
|
||
| // Step 2: Get validation ID from contract using nodeID | ||
| // For StakingManager, we need to query the underlying ValidatorManager |
There was a problem hiding this comment.
maybe lets change the name of the directory to Validator Manager - since now also the operations for permissionless l1s are in a permissioned l1s folder
Comment on lines
+142
to
+160
| let validationIdQueryAddress = validatorManagerAddress; | ||
|
|
||
| if (useStakingManager && contractOwner) { | ||
| // Get the underlying ValidatorManager address from StakingManager settings | ||
| try { | ||
| const settings = await publicClient.readContract({ | ||
| address: contractOwner as `0x${string}`, | ||
| abi: nativeTokenStakingManagerAbi.abi, | ||
| functionName: 'getStakingManagerSettings', | ||
| }) as any; | ||
|
|
||
| validationIdQueryAddress = settings.manager; // This is the actual ValidatorManager | ||
| console.log('[StakingManager] Querying ValidatorManager for validation ID:', validationIdQueryAddress); | ||
| } catch (err) { | ||
| console.warn("Failed to get ValidatorManager from StakingManager settings, using default:", err); | ||
| } | ||
| } | ||
|
|
||
| console.log('[CompleteValidatorRegistration] Querying validation ID from:', validationIdQueryAddress); |
There was a problem hiding this comment.
why do we need to store the validator manager address in a validationIdQueryAddress variable that then we set to the response of the rpc call?
in other words i think we can just delete line 142 i think
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.