Skip to content

fix: negative gas values#686

Merged
meeh0w merged 2 commits intonext-gen/code-freeze-fixesfrom
fix/negative-gas-values
Jan 13, 2026
Merged

fix: negative gas values#686
meeh0w merged 2 commits intonext-gen/code-freeze-fixesfrom
fix/negative-gas-values

Conversation

@meeh0w
Copy link
Member

@meeh0w meeh0w commented Jan 9, 2026

Changes

Prevents negative values from being used in custom gas settings

Testing

You should not be able to set negative values in Custom gas settings for EVM transactions

Checklist for the author

  • I've covered new/modified business logic with Jest test cases.
  • I've tested the changes myself before sending it to code review and QA.

Copy link
Contributor

@csabbee csabbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-

Comment on lines +227 to +232
onWheel={(e: WheelEvent<HTMLInputElement>) => {
// Prevent changing value by mouse wheel
if (e.target === document.activeElement) {
(document.activeElement as HTMLInputElement).blur();
}
}}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Explicit type of e parameter is redundant.
  2. For runtime safety, please consider type assertion instead of casting.
Suggested change
onWheel={(e: WheelEvent<HTMLInputElement>) => {
// Prevent changing value by mouse wheel
if (e.target === document.activeElement) {
(document.activeElement as HTMLInputElement).blur();
}
}}
onWheel={(e) => {
// Prevent changing value by mouse wheel
if (
e.target === document.activeElement &&
e.target instanceof HTMLElement
) {
e.target.blur();
}
}}

Copy link
Contributor

@vvava vvava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@meeh0w meeh0w merged commit 67683cf into next-gen/code-freeze-fixes Jan 13, 2026
3 checks passed
@meeh0w meeh0w deleted the fix/negative-gas-values branch January 13, 2026 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants