fix: negative gas values#686
Merged
meeh0w merged 2 commits intonext-gen/code-freeze-fixesfrom Jan 13, 2026
Merged
Conversation
Comment on lines
+227
to
+232
| onWheel={(e: WheelEvent<HTMLInputElement>) => { | ||
| // Prevent changing value by mouse wheel | ||
| if (e.target === document.activeElement) { | ||
| (document.activeElement as HTMLInputElement).blur(); | ||
| } | ||
| }} |
Contributor
There was a problem hiding this comment.
- Explicit type of
eparameter is redundant. - For runtime safety, please consider type assertion instead of casting.
Suggested change
| onWheel={(e: WheelEvent<HTMLInputElement>) => { | |
| // Prevent changing value by mouse wheel | |
| if (e.target === document.activeElement) { | |
| (document.activeElement as HTMLInputElement).blur(); | |
| } | |
| }} | |
| onWheel={(e) => { | |
| // Prevent changing value by mouse wheel | |
| if ( | |
| e.target === document.activeElement && | |
| e.target instanceof HTMLElement | |
| ) { | |
| e.target.blur(); | |
| } | |
| }} |
bartosz-the-coder-at-avalabs
previously requested changes
Jan 9, 2026
...es/Approve/components/ActionDetails/evm/EvmNetworkFeeWidget/components/CustomGasSettings.tsx
Outdated
Show resolved
Hide resolved
dd17f60 to
c24c8f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Changes
Prevents negative values from being used in custom gas settings
Testing
You should not be able to set negative values in
Customgas settings for EVM transactionsChecklist for the author