Open
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds support for ACP-236 (Auto-Renewed Validators) so wallets can parse and render the three new P-Chain transaction types end-to-end.
Related PRs:
Changes
@avalabs/vm-module-types) – introduce new staking tx shapes andTxTypevalues:AddAutoRenewedValidator–nodeID,stake,delegationFee,weight,autoCompoundRewardShares,period, optional BLSpublicKey/signatureSetAutoRenewedValidatorConfig– updatesperiodandautoCompoundRewardSharesfor an existing auto-renewed validatorRewardAutoRenewedValidator– references the original validator tx IDtransaction-detail-sections/that render Account, Node, Stake Amount, Delegation Fee, Cycle Duration and Compound Rewards %, plus the matching wiring inget-transaction-detail-sections.tsandparse-tx-details.ts. Unit handling convertsperiod(seconds → days) and PPM values (×10,000→ %).@avalabs/avalanchejs, wallet SDK and related packages to the versions that expose ACP-236 on-chain data; tests adjusted accordingly.getProvider()now takes aNetworkinstead of resolving it internally, simplifying callers inget-address,get-balances,get-network-fee,derive-addressandavalanche-send-transaction.Testing
yarn test)get-transaction-detail-sectionstests cover all three ACP-236 tx types