Skip to content

fix: fix alphabetical ordering of acme-proxy and acmetool in Security section - #6569

Closed
xlkv wants to merge 1 commit into
avelino:mainfrom
xlkv:fix-security-alphabetical-order
Closed

fix: fix alphabetical ordering of acme-proxy and acmetool in Security section#6569
xlkv wants to merge 1 commit into
avelino:mainfrom
xlkv:fix-security-alphabetical-order

Conversation

@xlkv

@xlkv xlkv commented Aug 10, 2026

Copy link
Copy Markdown

Fixes in by placing before in alphabetical order under the Security section.

… section

Fixes TestAlpha in main_test.go by placing acme-proxy before acmetool according to alphabetical order rules.
@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can reply 'qodo' on any finding to push back, ask questions, or dig deeper

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Fix Security section alphabetical ordering for acme-proxy vs acmetool

📝 Documentation 🕐 Less than 5 minutes

Grey Divider

AI Description

• Reorder Security list entries to maintain correct alphabetical sorting.
• Place acme-proxy before acmetool to match ordering rules.
High-Level Assessment

The current approach is optimal: directly reorder the two list items to restore alphabetical ordering with minimal change surface.

Files changed (1) +1 / -1

Documentation (1) +1 / -1
README.mdFix alphabetical order in Security section +1/-1

Fix alphabetical order in Security section

• Reorders two adjacent entries under the Security section so that acme-proxy appears before acmetool, maintaining alphabetical sorting consistency.

README.md

@qodo-code-review

Copy link
Copy Markdown

Qodo Fixer

No findings are available for this PR yet. Findings appear here once Qodo has reviewed the PR.

@github-actions

Copy link
Copy Markdown

Automated Quality Checks

Required checks

Repo link: missing from PR body

How to fix: Add the following to your PR description:

Forge link: https://github.com/your-org/your-project

❌ **pkg.go.dev**: missing from PR body
  > **How to fix:** Add the following to your PR description:
  > ```
pkg.go.dev: https://pkg.go.dev/github.com/your-org/your-project

Go Report Card: missing from PR body

How to fix: Add the following to your PR description:

goreportcard.com: https://goreportcard.com/report/github.com/your-org/your-project


### Additional checks

⚠️ **Coverage**: missing from PR body
  > **How to fix:** Add a coverage service link to your PR description:
  > ```
Coverage: https://app.codecov.io/gh/your-org/your-project

Popular options: Codecov, Coveralls. Integrate one with your CI to track coverage automatically.


Action needed: one or more required checks failed. Please update your PR body with the missing links and ensure the repository meets the quality standards.

These checks are automated and do not replace maintainer review. See CONTRIBUTING.md for full guidelines.


PR Diff Validation

Content checks

Files changed: only README.md
Description: ends with punctuation
Description tone: no promotional language detected
Category size: Security has 62 items

Warnings

⚠️ Changes: 1 added + 1 removed (update or move — please confirm in PR description)
⚠️ Link text: acmetool differs from repo name acme

How to fix: The link text should be the exact project name.
If the project name really is acmetool, this is fine. Otherwise change it to: - [acme](https://github.com/hlandau/acme) - ...

Automated diff validation — does not replace maintainer review.

@xlkv xlkv closed this by deleting the head repository Aug 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant