Add ServiceTimeout rule#3848
Draft
ConnorKirk wants to merge 2 commits intoaws-cloudformation:mainfrom
Draft
Conversation
7dd8d15 to
a8c746e
Compare
The ServiceTimeout rule emits a warning if the ServiceTimeout property is not specified for a CloudFormation Custom Resource.
a8c746e to
e96161f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#3834
Description of changes:
The ServiceTimeout rule emits a warning if the
ServiceTimeoutproperty is not specified for a CloudFormation Custom Resource.ServiceTimeoutClasstest_service_timeoutunit testservice_timeout.pyTodo
rules.md?Notes
AWS::CloudFormation::CustomResource, a custom resource type, prefixed witCustom::. I added a small helper function to find all custom resourcesBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.