Skip to content

add support for domainame #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

add support for domainame #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ee6967a
add support for domainame
rushmash91 Jul 15, 2025
2293554
fix tamer
rushmash91 Jul 16, 2025
0584afa
Merge branch 'main' into domainame
rushmash91 Jul 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions apis/v1alpha1/ack-generate-metadata.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
ack_generate_info:
build_date: "2025-07-15T03:20:54Z"
build_date: "2025-07-16T17:04:23Z"
build_hash: c6808295bbb03aac999713ecf1f3aa5cd698a17e
go_version: go1.24.4
go_version: go1.24.1
version: v0.49.0
api_directory_checksum: d82f4d79382f6fe41728ddbdfb5ec025b658575f
api_directory_checksum: 6c7aa5e131743e63ddf99d1e874b3226626847fa
api_version: v1alpha1
aws_sdk_go_version: v1.32.6
generator_config_info:
file_checksum: 94f4e735b9f53f4992c3402f108ea847d3d438f2
file_checksum: 45e066e9415a1e1b3233151ff955ff73e99f1449
original_file_name: generator.yaml
last_modification:
reason: API generation
165 changes: 165 additions & 0 deletions apis/v1alpha1/domain_name.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions apis/v1alpha1/enums.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 23 additions & 2 deletions apis/v1alpha1/generator.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ ignore:
# - Deployment
- DocumentationPart
- DocumentationVersion
- DomainName
# - DomainName
- DomainNameAccessAssociation
- Model
- RequestValidator
Expand Down Expand Up @@ -426,4 +426,25 @@ resources:
exceptions:
terminal_codes:
- BadRequestException
- InvalidParameter
- InvalidParameter
DomainName:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we rename the resource to DomainNameResource? A resource named DomainName doesn't feel right

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I think Domain name is better for this resource. What about it doesn't feel right?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would just be weird to have something like DomainName.Spec.DomainName or DomainName.Spec.Name..it feels very misleading to me..

fields:
DomainName:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could rename this to Name?

is_primary_key: true
is_required: true
Comment on lines +433 to +434
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if these two are needed..the model should have marked it as required

is_immutable: true
hooks:
sdk_update_pre_build_request:
template_path: hooks/domain_name/sdk_update_pre_build_request.go.tpl
sdk_update_post_build_request:
template_path: hooks/domain_name/sdk_update_post_build_request.go.tpl
exceptions:
terminal_codes:
- BadRequestException
- InvalidParameter
synced:
when:
- path: Status.DomainNameStatus
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe rename this to just Status as well?

in:
- AVAILABLE
- NOT_AVAILABLE
49 changes: 28 additions & 21 deletions apis/v1alpha1/types.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading