-
Notifications
You must be signed in to change notification settings - Fork 12
add support for domainame #48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,13 +1,13 @@ | ||
ack_generate_info: | ||
build_date: "2025-07-15T03:20:54Z" | ||
build_date: "2025-07-16T17:04:23Z" | ||
build_hash: c6808295bbb03aac999713ecf1f3aa5cd698a17e | ||
go_version: go1.24.4 | ||
go_version: go1.24.1 | ||
version: v0.49.0 | ||
api_directory_checksum: d82f4d79382f6fe41728ddbdfb5ec025b658575f | ||
api_directory_checksum: 6c7aa5e131743e63ddf99d1e874b3226626847fa | ||
api_version: v1alpha1 | ||
aws_sdk_go_version: v1.32.6 | ||
generator_config_info: | ||
file_checksum: 94f4e735b9f53f4992c3402f108ea847d3d438f2 | ||
file_checksum: 45e066e9415a1e1b3233151ff955ff73e99f1449 | ||
original_file_name: generator.yaml | ||
last_modification: | ||
reason: API generation |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -49,7 +49,7 @@ ignore: | |
# - Deployment | ||
- DocumentationPart | ||
- DocumentationVersion | ||
- DomainName | ||
# - DomainName | ||
- DomainNameAccessAssociation | ||
- Model | ||
- RequestValidator | ||
|
@@ -426,4 +426,25 @@ resources: | |
exceptions: | ||
terminal_codes: | ||
- BadRequestException | ||
- InvalidParameter | ||
- InvalidParameter | ||
DomainName: | ||
fields: | ||
DomainName: | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we could rename this to Name? |
||
is_primary_key: true | ||
is_required: true | ||
Comment on lines
+433
to
+434
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. not sure if these two are needed..the model should have marked it as required |
||
is_immutable: true | ||
hooks: | ||
sdk_update_pre_build_request: | ||
template_path: hooks/domain_name/sdk_update_pre_build_request.go.tpl | ||
sdk_update_post_build_request: | ||
template_path: hooks/domain_name/sdk_update_post_build_request.go.tpl | ||
exceptions: | ||
terminal_codes: | ||
- BadRequestException | ||
- InvalidParameter | ||
synced: | ||
when: | ||
- path: Status.DomainNameStatus | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. maybe rename this to just Status as well? |
||
in: | ||
- AVAILABLE | ||
- NOT_AVAILABLE |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we rename the resource to DomainNameResource? A resource named DomainName doesn't feel right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm I think Domain name is better for this resource. What about it doesn't feel right?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would just be weird to have something like
DomainName.Spec.DomainName
orDomainName.Spec.Name
..it feels very misleading to me..