Skip to content

feat(helm): refactoring Kubernetes recommanded labels#619

Open
nlamirault wants to merge 1 commit intoaws-controllers-k8s:mainfrom
nlamirault:feat/k8s-recommanded-labels
Open

feat(helm): refactoring Kubernetes recommanded labels#619
nlamirault wants to merge 1 commit intoaws-controllers-k8s:mainfrom
nlamirault:feat/k8s-recommanded-labels

Conversation

@nlamirault
Copy link

@nlamirault nlamirault commented Aug 21, 2025

  • Support all Kubernetes recommended labels
  • Refactoring using template helper.
  • Support for additional labels which can be add to all resources
  • Change labelSelector into metrics-service to use the same of the deployment.

See also: aws-controllers-k8s/s3-controller#175

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Nicolas Lamirault <nicolas.lamirault@gmail.com>
@ack-prow ack-prow bot requested review from jlbutler and rushmash91 August 21, 2025 07:21
@ack-prow
Copy link

ack-prow bot commented Aug 21, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: nlamirault
Once this PR has been reviewed and has the lgtm label, please assign knottnt for approval by writing /assign @knottnt in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 21, 2025
@ack-prow
Copy link

ack-prow bot commented Aug 21, 2025

Hi @nlamirault. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-bot
Copy link
Collaborator

ack-bot commented Feb 17, 2026

Issues go stale after 180d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 60d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.
Provide feedback via https://github.com/aws-controllers-k8s/community.
/lifecycle stale

@ack-prow ack-prow bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants