Skip to content

Conversation

vijaydandu
Copy link

fixes aws-controllers-k8s/community#2625

Description of changes:

  • reads enableCARM value from values.json
  • supplies arg to controller to disable CARM when set to false

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ack-prow ack-prow bot requested review from knottnt and michaelhtm September 16, 2025 03:43
Copy link

ack-prow bot commented Sep 16, 2025

Hi @vijaydandu. Thanks for your PR.

I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ack-prow ack-prow bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 16, 2025
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @vijaydandu ! i left a couple comments below

@a-hilaly
Copy link
Member

/ok-to-test

@ack-prow ack-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 16, 2025
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ack-prow ack-prow bot added the approved label Sep 16, 2025
@a-hilaly
Copy link
Member

/lgtm

@ack-prow ack-prow bot added the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2025
Copy link

ack-prow bot commented Sep 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: a-hilaly, vijaydandu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@vijaydandu vijaydandu changed the title feat: reads enableCARM value and supplies to controller if disabled feat: reads enableCARM value and supplies to controller Sep 16, 2025
@vijaydandu
Copy link
Author

/retest

@ack-prow ack-prow bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 16, 2025
Copy link

ack-prow bot commented Sep 16, 2025

New changes are detected. LGTM label has been removed.

@vijaydandu
Copy link
Author

/retest

2 similar comments
@vijaydandu
Copy link
Author

/retest

@vijaydandu
Copy link
Author

/retest

Copy link

ack-prow bot commented Sep 16, 2025

@vijaydandu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
verify-attribution ad989a7 link false /test verify-attribution
s3-olm-test ad989a7 link false /test s3-olm-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ok-to-test Indicates a non-member PR verified by an org member that is safe to test.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ACK controllers crashloop on namespace scope
3 participants