Implemented a fallback parameter validation for DbClusterParameterGroup #230
+236
−7
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes aws-controllers-k8s/community#1847
DbClusterParameterGroup
was incorrectly rejecting valid parameters likeslow_query_log
,long_query_time
, andlog_queries_not_using_indexes
with "unknown parameter" errors. This occurred because the controller only validated parameters againstDescribeEngineDefaultClusterParameters
API, but some valid cluster parameters (particularly MySQL logging parameters) are only listed in theDescribeEngineDefaultParameters
(instance-level) API response.Description of changes:
Implemented a fallback parameter validation mechanism in
getParameterMeta()
that first checks cluster-level parameter defaults, and if not found, falls back to instance-level parameter defaults before rejecting a parameter as unknown. This allows the controller to properly validate and apply parameters that AWS RDS Console and CLI support but weren't previously accessible through the ACK controller, while maintaining backward compatibility and proper parameter metadata handling for apply methods and modifiability checks.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.